490673 - WebServices broken in trunk because of datetime_format method missing

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

import xmlrpclib
bzilla = xmlrpclib.ServerProxy("https://landfill.bugzilla.org/bugzilla-tip/xmlrpc.cgi")
print bzilla.Bug.search({'id':'6323'})

raises:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/xmlrpclib.py", line 1199, in __call__
    return self.__send(self.__name, args)
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/xmlrpclib.py", line 1489, in __request
    verbose=self.__verbose
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/xmlrpclib.py", line 1253, in request
    return self._parse_response(h.getfile(), sock)
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/xmlrpclib.py", line 1392, in _parse_response
    return u.close()
  File "/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/xmlrpclib.py", line 838, in close
    raise Fault(**self._stack[0])
xmlrpclib.Fault: <Fault -32000: 'Can\'t locate object method "datetime_format" via package "Bugzilla::WebService::Bug" at /var/www/html/bugzilla-tip/Bugzilla/WebService.pm line 39.\n'>

Comment 1

[Tiago Mello [:timello]]

Attachment: Possible fix

Not sure if that is the best/right fix...

Comment 2

[Tiago Mello [:timello]]

Comment on attachment 375068 [details] [diff] [review]
Possible fix

>Index: Bugzilla/WebService/Server/XMLRPC.pm
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Server/XMLRPC.pm,v
>retrieving revision 1.2
>diff -u -p -r1.2 XMLRPC.pm
>--- Bugzilla/WebService/Server/XMLRPC.pm	31 Mar 2009 06:37:59 -0000	1.2
>+++ Bugzilla/WebService/Server/XMLRPC.pm	29 Apr 2009 18:40:33 -0000
>@@ -20,6 +20,7 @@ package Bugzilla::WebService::Server::XM
> use strict;
> use XMLRPC::Transport::HTTP;
> use Bugzilla::WebService::Server;
>+use HTTP::Date;

Please, forget this change. This is not needed.

> our @ISA = qw(XMLRPC::Transport::HTTP::CGI Bugzilla::WebService::Server);
> 
> use Bugzilla::WebService::Constants;

Comment 3

[Max Kanat-Alexander]

Comment on attachment 375068 [details] [diff] [review]
Possible fix

No, that's not right. datetime_format is a Bugzilla-specific method, not something from HTTP::Date.

Comment 4

[Frédéric Buclin]

Is 3.4 affected too? If yes, then that's a blocker.

Comment 5

[Teemu Mannermaa (:wicked)]

I don't think v3.4 is affected because datetime_format sub was removed in bug 432907 (it was in WebService.pm). I also tested this on 3.4 but it failed with a different error and not this one (bug 490675).

Comment 6

[Max Kanat-Alexander]

Attachment: v1

It doesn't affect 3.4. This fixes it. datetime_format was just in the wrong place.

Comment 7

[Teemu Mannermaa (:wicked)]

Comment on attachment 375083 [details] [diff] [review]
v1

Looks good and tested to fix the Bug.get_history API.

I guess that "double datetime_format call" doesn't need to be backported to 3.4 since it doesn't seem to cause any noticeable problems there for that API.

Comment 8

[Max Kanat-Alexander]

Checking in Bugzilla/WebService.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService.pm,v  <--  WebService.pm
new revision: 1.19; previous revision: 1.18
done
Checking in Bugzilla/WebService/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Bug.pm,v  <--  Bug.pm
new revision: 1.36; previous revision: 1.35
done
Checking in Bugzilla/WebService/Server/XMLRPC.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/WebService/Server/XMLRPC.pm,v  <--  XMLRPC.pm
new revision: 1.3; previous revision: 1.2
done